Revert "Remove locking from DBs and rely on SQLite's locking (#211)" #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7d08813.
|
I've tried this on |
JehandadKhan
requested changes
May 21, 2020
| // clang-format off | ||
| const auto check_tables = | ||
| "SELECT name FROM sqlite_master " | ||
| "WHERE " | ||
| "type = 'table' AND " | ||
| "(name = 'config');"; | ||
| "(name = 'config' OR name = 'perf_db');"; |
There was a problem hiding this comment.
This masks a bug, if only one of the tables is created.
There was a problem hiding this comment.
If this fixes the Jenkins issue then you can implement this fix, but leave off the rest of the locking changes.
|
@daniellowell Did we find the root cause ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7d08813.
Suspected commit in Jenkins Failures.