Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop branch for release after ROCm 6.3 #898

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Develop branch for release after ROCm 6.3 #898

merged 1 commit into from
Aug 22, 2024

Conversation

daineAMD
Copy link
Contributor

@daineAMD daineAMD commented Aug 6, 2024

  • hipBLAS version 2.3.0 -> 2.4.0
  • rocBLAS dependency version 4.3.0 -> 4.4.0
  • rocSOLVER dependency version 3.27.0 -> 3.28.0

Awaiting confirmation of rocSOLVER version number, will leave as a draft and noCI until rocSOLVER is ready. Also removed old bump_master_version.sh since it isn't used anymore.

release-staging/rocm-rel-6.3 has been created from develop with no version changes.

@daineAMD daineAMD added the noCI Disable Jenkins for this PR. label Aug 6, 2024
@daineAMD daineAMD mentioned this pull request Aug 7, 2024
Closed
amcamd
amcamd reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@amcamd amcamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • hipBLAS version has major field increment of 1, this is correct
  • rocBLAS version has major field increment of 1, this is correct
  • release-staging/rocm-rel-6.3 is the same as develop, this is correct
  • Waiting for rocSOLVER to approve

@daineAMD daineAMD marked this pull request as ready for review August 21, 2024 22:34
@daineAMD daineAMD removed the noCI Disable Jenkins for this PR. label Aug 21, 2024
TorreZuk
TorreZuk approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump looks correct to me

@daineAMD daineAMD merged commit 7e6a192 into ROCm:develop Aug 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcamd amcamd amcamd left review comments

@TorreZuk TorreZuk TorreZuk approved these changes

@jzuniga-amd jzuniga-amd jzuniga-amd approved these changes

@mahmoodw mahmoodw Awaiting requested review from mahmoodw mahmoodw is a code owner

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@NaveenElumalaiAMD NaveenElumalaiAMD Awaiting requested review from NaveenElumalaiAMD NaveenElumalaiAMD is a code owner

@rkamd rkamd Awaiting requested review from rkamd rkamd is a code owner

@tfalders tfalders Awaiting requested review from tfalders

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daineAMD @amcamd @TorreZuk @jzuniga-amd