Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable scan tests, re-enable tests on gfx11xx #449

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Temporarily disable scan tests, re-enable tests on gfx11xx #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de96fa8
Remove Thrust comments referencing website (#447)
umfranzw Aug 19, 2024
8b6d20d
Temporarily disable scan tests, re-enable tests on gfx11xx
umfranzw Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .jenkins/common.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,8 @@ def runTestCommand (platform, project)

def testCommand = "ctest --output-on-failure"
def hmmTestCommand = ''
def excludeRegex = 'reduce_by_key.hip'

if (platform.jenkinsLabel.contains('gfx11'))
{
excludeRegex = /(reduce_by_key.hip|partition.hip|sort.hip|sort_by_key.hip|stable_sort_by_key.hip|stable_sort.hip|async_copy.hip|async_reduce.hip|async_scan.hip|async_sort.hip|async_transform.hip)/
}
// Note: temporarily disable scan tests below while waiting for a compiler fix
def excludeRegex = /(reduce_by_key.hip|scan)/
testCommandExclude = "--exclude-regex \"${excludeRegex}\""

if (platform.jenkinsLabel.contains('gfx90a'))
Expand Down
2 changes: 0 additions & 2 deletions thrust/optional.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ template <class T> struct is_const_or_const_ref<T const> : std::true_type{};
#endif

// std::invoke from C++17
// https://stackoverflow.com/questions/38288042/c11-14-invoke-workaround
__thrust_exec_check_disable__
template <typename Fn, typename... Args,
#ifdef THRUST_OPTIONAL_LIBCXX_MEM_FN_WORKAROUND
Expand Down Expand Up @@ -336,7 +335,6 @@ template <class T, class U = T> struct is_swappable : std::true_type {};

template <class T, class U = T> struct is_nothrow_swappable : std::true_type {};
#else
// https://stackoverflow.com/questions/26744589/what-is-a-proper-way-to-implement-is-swappable-to-test-for-the-swappable-concept
namespace swap_adl_tests {
// if swap ADL finds this then it would call std::swap otherwise (same
// signature)
Expand Down