Test suite - hip build fix #453
Open
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Sep 19, 2024
r-abishek
commented
- Add fix for test suite hip build
|
@r-abishek can you add the fix for Issue #454 here? |
RPP Test Suite : Include Iomanip header
|
@kiritigowda Added iomanip PR updates here - r-abishek#344 |
|
@r-abishek any updates on this PR? Need the fix to solve test failures |
|
@r-abishek : We need to merge this PR asap as CI is failing on bunch of PRs. Is it still WIP? |
rrawther
reviewed
Oct 2, 2024
|
@kiritigowda @rrawther Please see screenshots below with lsb_release -a command to show Ubuntu passing on 22.04 and 20.04: Passing on Ubuntu 22.04: Passing on Ubuntu 20.04: |
|
@kiritigowda @rrawther Current fails on CI are just since the right libs are not installed on the CI machine for both SLES and RHEL: On RHEL9: On SLES15: |
|
@r-abishek - we are installing all the deps for CI. The failure on RHEL 8 can be verified with this fix. |
rrawther
approved these changes
Oct 7, 2024
kiritigowda
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.