Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: cleanup code & fixes #110

Merged
merged 5 commits into from
Jun 10, 2022
Merged

refact: cleanup code & fixes #110

merged 5 commits into from
Jun 10, 2022

Conversation

kkafar
Copy link
Collaborator

@kkafar kkafar commented Jun 9, 2022

Description

Checklist

  • Included code to test these changes
  • Updated Jira

@kkafar kkafar changed the title refact: move constants to separate registry refact: cleanup code & fixes Jun 9, 2022
@kkafar kkafar marked this pull request as ready for review June 9, 2022 21:33
@kkafar kkafar requested review from co012 and mhawryluk and removed request for co012 June 9, 2022 21:33
co012
co012 approved these changes Jun 10, 2022
View reviewed changes
Copy link
Collaborator

@co012 co012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkafar kkafar merged commit ac065cb into master Jun 10, 2022
@kkafar kkafar deleted the @kkafar/improve-code-quality branch June 10, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@co012 co012 co012 approved these changes

@mhawryluk mhawryluk Awaiting requested review from mhawryluk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkafar @co012