Create TextPopup and TextImagePopup #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
approved these changes
May 1, 2022
|
trzeba to gdzieś wkleić (readme?), żeby korzystać z tych grafik: Wood button vector created by upklyak - www.freepik.com |
|
Sensownie będzie może jakiegoś małego doca zrobić? ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created popups that can be used when implementing various Actions!
TextPopup displays a text, while TextImagePopup displays both a text and an image. Both of them have an "okButton" that currently closes the popup stage, but can be configured to do something else. Popups can also be closed by clicking aside, but that feature could be removed.
Popup constructors can accept paths to assets to configure their graphics, but it's not being used right now. I think that's an issue for another task in this sprint.
How to use the popups
Call an appropriate method from the PopupController, passing what should be displayed, as well as x and y -> position at which the popup center will appear. x and y are most likely the results of Controller.getWindowCenterX and Controller.getWindowCenterY respectively.
Test the new popups
type in 'F' -> open the new TextImagePopup for earned points
type in 'G' -> open the new "hello" TextPopup
pick up items -> another example of a TextImagePopup
Challenge
Take a shot every time I used the word popup here.
Checklist