feat: Popup asset configuration #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: bound crossing is working * chore: use more precise teleport * fix: strange direction vector fix * refact: remove redundant whitespace * refact: remove redundant whitespace Co-authored-by: Kacper Kafara <kacperkafara@gmail.com>
* chore: created action for battle * Update src/test/java/io/rpg/battle/BattleTest.java Co-authored-by: Marcin Hawryluk <70582973+mhawryluk@users.noreply.github.com> * Update src/test/java/io/rpg/battle/BattleTest.java Co-authored-by: Marcin Hawryluk <70582973+mhawryluk@users.noreply.github.com> * Update src/test/java/io/rpg/battle/BattleTest.java Co-authored-by: Marcin Hawryluk <70582973+mhawryluk@users.noreply.github.com> * fix: removed player from battleAction Co-authored-by: Marcin Hawryluk <70582973+mhawryluk@users.noreply.github.com>
…IO/rpg-io into @mhawryluk/RPG-7-popup-asset-config
* chore: add @NotNull annotation for Stage param in Initializer#ctor This object is created by JavaFX and can not be null rn. * chore: add ErrorMessageBuilder Util class for comfort only. Allows easier construction of error messages. * refact: make use of ErrorMessageBuilder * refact: move object description creation to separate class * chore: add protype for ActionConfig * chore: chanage actionTypeString field name in JSON to type * docs: add docs for root.json file * docs: add configuration docs This is initial version. Many fixes & upgrades are still required. Feel free to comment / develop. * refact: Main These changes should not be commited here, but I had to... * chore: add no-args factory methods to Result class * refact: rename Result#error -> Result#err * refact: rename Result#getErrorValue -> Result#getErrValue * refact: rename Result#isError -> Result#isErr * docs: add missing JavaDoc comments in Result class * chore: change nullability of result value in Result class This is handy as IntelliJ can not detect that returned value is not null after result has been checked with isOkValueNull... This can be pulled off now, as isErrorValueNull && isOkValueNull methods are exposed. * chore: extend pool of working serialized names for config files * feat: add detection of locations based on locations directory * chore: add dependency on apache commons I/O for removeExtension method * chore: bump dependencies versions * chore: add object externally declared in demo-config * fix: data object description generation * feat: allow for external object & location config specification * chore: return error when object config loading fails * chore: add better error handlig in object creation * chore: remove binding between object-type and performed action * fix: merge artifact * chore: remove redundatn action type check * feat: add more specific event types onClick, onLeftClick, onRightClick * chore: add description field to GamebObjectConfig * refact: remove whitespace in GameEndAction * chore: add possibility to update description * chore: remove final modiers from ActionConfig * feat: add before & after action hooks * chore: update docs * chore: remove leftover enum GameObject.Type As there are no longer GameObject types (we moved towards action defined behaviours) this enum type is redundant * feat: add fields for modeling all available action types (as for now) * refact: rename ActionConfig -> ActionConfigBundle * chore: add ActionType enum * feat: add stub validation mdethods in ActionConfigBundle * chore: change type of actionType field from String to ActionType (enum) * fix: GameObject factory method * chore: initial implementation of ActionFactory * feat: add missing position field to ActionConfigBundle * chore: add ActionFactory version alpha * fix: open io.rpg.model.actions to google.gson * fix: remove invalid assertion * feat: set actions on actual GameObjects * chore: add alternate name for question field in Question * docs: update docs * chore: remove comment Text is already being loaded from config * fix: add missing getStrength method * fix: handle null config for action
Merge branch 'development' into @mhawryluk/RPG-7-popup-asset-config
kkafar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist