Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the eggress node handling functionality #137

Merged
merged 3 commits into from
Apr 16, 2020

Conversation

adnan904
Copy link
Contributor

  • A node can be set to be a Egress node in the type attribute of the network file
  • If some nodes are set as Egress then only the simulator will randomly choose one of them as the Egress node for each flow
  • If some nodes are set to be Egress then once the flow is processed we check if for the flow, current node == egress node . If Yes then we depart , otherwise we forward the flow to the egress_node using the shortest_path.
  • Ideally the coordination algorithms should keep the path(Ingress to Egress) of the flow in view while creating the schedule/placement. That is something we should check/implement for our DRL agent to use this feature.
  • closes #135

Copy link
Member

@stefanbschneider stefanbschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if it's tested and works!

Could you add a short description/example in the readme? Or jsut link this PR, where you described how to use it.

Copy link
Member

@qarawlus qarawlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through everything. It all looks good and well written. Good job!

@adnan904 adnan904 merged commit fab915c into RealVNF:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge PR BA Lars
3 participants