FIX: --version output in containers #493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the
--version
output from containers would includedirty
, indicating uncommitted changes. This was because/docs
was not copied into the docker images.Before this commit, the version output looks like this:
And after this commit, the version is:
Note the lack of
.dirty
in the output.By excluding
/docs
from the Docker images, we were modifying the state of the git repository, andgit status
was reporting uncommitted changes. This caused the commandneurodocker --version
to show that there were uncommitted changes (by including thedirty
suffix in the version). We do not want users to be under the impression that the version includes uncommitted changes. Indeed, kaczmarj excluded/docs
from the docker builds as a premature optimization... it turns out that they only consume 136 kb, which is negligible.