Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] add regression test for 498 #499

Merged
merged 2 commits into from
Jan 18, 2023
Merged

[FIX] add regression test for 498 #499

merged 2 commits into from
Jan 18, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Jan 18, 2023 •
edited
Loading

relates to #498

added as an expected fail for now

passes in 0.9.1 but fails on 0.9.3

@Remi-Gau Remi-Gau mentioned this pull request Jan 18, 2023
Closed
@kaczmarj kaczmarj mentioned this pull request Jan 18, 2023
Merged
@kaczmarj
Copy link
Collaborator

@Remi-Gau - do you want to close this pr and re-open it as a pr into the branch fix/issue-498? i opened a pr that should fix this in #500 . also woohoo neurodocker's 500th issue/pr!! 🎉 🚀

@kaczmarj
Copy link
Collaborator

better yet, i will merge this into master and then incorporate it into #500

@kaczmarj kaczmarj merged commit e867ba6 into ReproNim:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Remi-Gau @kaczmarj