-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs on finding the root dataset #198
Conversation
9e883d5
to
0cd3993
Compare
b074739
to
fe6e479
Compare
Re: the nested crate example, it would be nice to recommend adding a {
"@id": "http://example.org/crate/nested/",
"@type": "Dataset",
"conformsTo": {"@id": "https://w3id.org/ro/crate/1.2-DRAFT"}
} I haven't included that in this PR since in the current spec the |
We agreed that implementation can try to be lax and rescue user -- but spec should be more strict. Don't suggest the heuristics. Just note to not expose internals of nested crates as it could confuse root dataset algorithm. |
@stain #183 was closed yesterday but this PR is still open.
Commits 588e536, fe6e479 and e15f6ae did just that. Is there anything else that's preventing this PR from being merged? |
@Stian where is this up to? |
Merging without review as call 2023-03-23 agreed to merge all outstanding PR (that are not WIP) so we can do an overall review and push out 1.2. |
Updates the root data entity section as follows:
https://example.org/crate/ro-crate-metadata.json
) when the root data entity is also an absolute URI.ro-crate-metadata.json
(or absolute URI whose last path segment isro-crate-metadata.json
) entry. This makes the algorithm simpler and more efficient in the "standard" case of a single entry with an@id
ofro-crate-metadata.json
(see Support detached crates ro-crate-py#119).Note that, in order to make this PR independent from #189, I've avoided using the term "detached crate". If we merge that PR first, however, we should change this one to explicitly mention detached crates.