Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sha2 feature with oid subfeature enabled #255

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Conversation

tarcieri
Copy link
Member

We seem to be running into a lot of people who are having trouble with PKCS#1 v1.5 signatures because the failure mode for the oid feature of the sha2 crate being disabled is fairly unscrutable.

See #234, #253, and the semi-related tracking issue for #238.

If rsa has a sha2 feature, we can always ensure oid is enabled, and this can be used in code examples. It also means users don't need two crates to create/verify PKCS#1 v1.5 signatures.

RSA is used commonly enough with the SHA2 family that this integration probably makes sense.

cc @lumag

We seem to be running into a lot of people who are having trouble with
PKCS#1 v1.5 signatures because the failure mode for the `oid` feature of
the `sha2` crate being disabled is fairly unscrutable.

See #234, #253, and the semi-related tracking issue for #238.

If `rsa` has a `sha2` feature, we can always ensure `oid` is enabled,
and this can be used in code examples. It also means users don't need
two crates to create/verify PKCS#1 v1.5 signatures.

RSA is used commonly enough with the SHA2 family that this integration
probably makes sense.
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@tarcieri tarcieri merged commit 134a061 into master Jan 20, 2023
@tarcieri tarcieri deleted the sha2-feature branch January 20, 2023 23:46
@tarcieri tarcieri mentioned this pull request Jan 21, 2023
tarcieri added a commit that referenced this pull request Jan 21, 2023
Uses `rsa::sha2` to access `Sha256` in the code example, noting the
`sha2` feature must be enabled, ala #255
tarcieri added a commit that referenced this pull request Jan 21, 2023
Uses `rsa::sha2` to access `Sha256` in the code example, noting the
`sha2` feature must be enabled, ala #255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants