Add support for encrypted name id in encrypted assertion #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove validation error when document contains a decrypted name id
|
Can yo fix the lint error? |
|
Hey @pitbulk, I saw the run failed due to PHP Sniffer. I use a different intended / formatting tool at my IDEA. I'll fix the 'if' statement and request again. Best |
|
@pitbulk fixed the lint error. Please allow the workflow to run again. |
|
@pitbulk quick check in, could you please run the workflow again and merge the pull request if successful? Best |
pitbulk
added a commit
that referenced
this pull request
Sep 29, 2024
|
@pitbulk thank you for merging. When will this be included in a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @pitbulk,
this is the PR for the issue #318. I added a check for the existence of an
EncryptedIDelement during the decryption of the assertion. If it exists, the same method can be called recursively to decrypt the encrypted name id.I also removed the validation error, that throws when an encrypted name id is detected in an encrypted assertion, since this is supported with this PR.
I added a signed SAML response with encrypted assertion that contains an encrypted name id to the test data and wrote a test case to ensure the validation of the response and the correct retrieving of the name id.
Let me know if that works for you, or you miss anything.
Best
Julius