fix(ui5-toolbar-button): ensure getDomRef() returns the actual DOM reference #10009
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ference This commit fixes the issue where `getDomRef()` on `ui5-toolbar-button` was returning `undefined` by providing a custom implementation that correctly returns the DOM reference to the actual `ui5-button` element rendered within the `ui5-toolbar`'s shadow DOM. This enhancement ensures that developers can reliably interact with the toolbar button's DOM element. **Notes:** - This fix assumes that `ui5-toolbar-button` is a direct child of `ui5-toolbar`. - If the component hierarchy changes, additional checks may be necessary to ensure the parent toolbar is correctly identified. Fixes: #9996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue where
getDomRef()onui5-toolbar-buttonwas returningundefinedby providing a custom implementation that correctly returns the DOM reference to the actualui5-buttonelement rendered within theui5-toolbar's shadow DOM. This enhancement ensures that developers can reliably interact with the toolbar button's DOM element.Notes:
ui5-toolbar-buttonis a direct child ofui5-toolbar.Fixes: #9996