-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-slider, ui5-range-slider): add input as a tooltip #9547
Conversation
fix mouse and shortcuts movement bugs
remove the 'focused' property
and F2 shortcut support and acc attributes to the ui5-slider
fix accessibility issues
apply the accessibility improvements to the range slider
rename the property
…components into slider-input-tooltip
fix the test pages
fix and add tests for ui5-slider
add handle-container part, fix ui5-color-picker
F2: should toggle focus to the handle to the input and back, now it traps in the input field |
We should discuss the arrow up/down behavior - |
apply code review feedback
apply code review feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- .aria-describedby renders describedby even if there is no value. Please return undefined in the getter
- where it is specified that the input of the slider receives the accessible name passed to the slider? I checked the acc spec and there is no such info for the inputs. I would expect that the elements with role slider will receive accessible-name/accessible-name-ref, not the input. The same is described in the ACC spec.
- Currently you pass ui5-slider-accName even if ui5-slider-accName is empty, it should not be rendered as a span and also as an aria-label
@@ -5,7 +5,7 @@ | |||
@mouseover="{{_onmouseover}}" | |||
@mouseout="{{_onmouseout}}" | |||
@keydown="{{_onkeydown}}" | |||
@keyup="{{_onkeyup}}" | |||
@keyup="{{_onKeyupBase}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not call it _onkeyup in the base? Slider does not have a keyup so it will call the super class and RangleSlider has the keyup and it will call its keyup method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyup has a parameter and the function is the base doesn't, the typescript linter is complaining, that's why i made 2 separate functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still lots of disable-line, can we fix it?
Issue 1
- Open: http://localhost:8080/packages/main/test/pages/RangeSlider.html
- Go to
Range Slider with steps, tooltips, tickmarks and labels
- Click on the second (12) handle's tooltip input
- Type 60 and Hit Enter
- 2 is returned?
issue 2
- Select any of the inputs
- Select all (command / control + a)
- Type
-
(to start typing e.g.-2
) - Value is clear?
issue 3
- Select any of the inputs
- Select all (command / control + a)
- Type
0
hit Enter - tooltip disapers?
issue 4
- Open: http://localhost:8080/packages/main/test/pages/RangeSlider.html
- Select first input
- Type 14, hit Enter
- Type 16 hit Enter
- Value is not changed?
Issue 2 is a bug in the |
fix slider test
remove the slider's accessible name from the tooltip input and othe minor improvements acc improvements
minor css improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues found during testing:
- Focus tooltip with value
2
- Change it to
12
hit Enter - Arrow Up + Enter
- Arrow Down + Enter
- Arrow down + Enter
Issue: Tooltip value is 11 but the slider valu is 12 for on of the tooltips
fix code review bug
Hi, Please update the documentation to fullfill the Acceptance Criteria of the BLI. |
add documentation to the new property
update documentation
fix translatable string
update documentation
Implement editable tooltips in
ui5-slider
andui5-range-slider