Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test for RobustScaler hash #902

Closed
Tarmandan opened this issue Jul 12, 2024 · 1 comment · Fixed by #905
Closed

test: Add test for RobustScaler hash #902

Tarmandan opened this issue Jul 12, 2024 · 1 comment · Fixed by #905
Assignees
@Tarmandan
Labels
lab Suitable for the lab released Included in a release team1 testing 🧪 Additional automated tests

Comments

@Tarmandan
Copy link
Contributor

Tarmandan commented Jul 12, 2024 •
edited
Loading

Is your feature request related to a problem?

The __hash__ method of RobustScaler is not tested.

Desired solution

RobustScaler should be added to the list of Transformers tested in test_table_transformer.py

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@Tarmandan Tarmandan added enhancement 💡 New feature or request lab Suitable for the lab labels Jul 12, 2024
@lars-reimann lars-reimann added testing 🧪 Additional automated tests and removed enhancement 💡 New feature or request labels Jul 12, 2024
@Tarmandan Tarmandan self-assigned this Jul 12, 2024
@Tarmandan Tarmandan mentioned this issue Jul 12, 2024
Merged
@Tarmandan Tarmandan linked a pull request Jul 12, 2024 that will close this issue
test: Added RobustScaler to test_table_transformer.py #905
Merged
lars-reimann pushed a commit that referenced this issue Jul 12, 2024
@Tarmandan
test: Added RobustScaler to test_table_transformer.py (#905)
254617c 
Closes #902

### Summary of Changes

Test coverage for RobustScaler.\_\_ hash\_\_() by adding RobustScaler to
the list of Numeric Table Transformers in test_table_transformer.py

Co-authored-by: Simon <simon@schwubbel.dip0.t-ipconnect.de>
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tarmandan Tarmandan

Labels
lab Suitable for the lab released Included in a release team1 testing 🧪 Additional automated tests
Projects
Library
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Added RobustScaler to test_table_transformer.py Safe-DS/Library
2 participants
@lars-reimann @Tarmandan