Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add continuous prediction to output conversion #741

Closed

Conversation

Gerhardsa0
Copy link
Contributor

Closes #740

Summary of Changes

I added a continues prediction for time series.

As example w.o. continues:
we want to predict values with forecast horizon 3, we only predict one value with 3 steps into the future.
With continues, all values until the forecast horizon (forecast horizon is included) will be predicted. This brought one problem up, as we don't store list values in our Columns. So I decided to make a new column for every step in the forecast horizon.
so with 3 there will be 3 prediction columns: prediction 0, prediction 1, prediction 2

Any Ideas on this behavior? @lars-reimann @Marsmaennchen221 @sibre28

@Gerhardsa0 Gerhardsa0 requested a review from a team as a code owner May 8, 2024 16:36
@Gerhardsa0 Gerhardsa0 linked an issue May 8, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented May 8, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 5 0 0 0.96s
✅ PYTHON mypy 5 0 2.74s
✅ PYTHON ruff 5 0 0 0.3s
✅ REPOSITORY git_diff yes no 0.46s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0564b52) to head (94ee24d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #741   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        79           
  Lines         5848      5858   +10     
=========================================
+ Hits          5848      5858   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gerhardsa0 Gerhardsa0 self-assigned this May 8, 2024
@lars-reimann lars-reimann changed the title feat: 740 feat add continues prediction to outputconvertion feat: add continues prediction to outputconvertion May 8, 2024
@lars-reimann lars-reimann changed the title feat: add continues prediction to outputconvertion feat: add continuous prediction to output conversion May 8, 2024
@lars-reimann
Copy link
Member

lars-reimann commented May 8, 2024

The upcoming polars-based implementation allows storing lists inside of columns. See the experimental tabular containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add continues prediction to OutPutconvertion
3 participants