feat: add KNearestNeighborsImputer #864

SamanHushi · 2024-06-28T08:12:09Z

Closes #743

Summary of Changes

Added KNN Imputer and Tests for it

github-actions · 2024-06-28T08:13:31Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	4	0	0	1.07s
✅ PYTHON	mypy	4		0	2.52s
✅ PYTHON	ruff	4	0	0	0.4s
✅ REPOSITORY	git_diff	yes		no	0.39s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

codecov · 2024-06-28T08:19:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (62320a3) to head (c63833a).
Report is 39 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
+ Coverage   97.65%   97.67%   +0.02%     
==========================================
  Files         119      120       +1     
  Lines        6178     6234      +56     
==========================================
+ Hits         6033     6089      +56     
  Misses        145      145

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/safeds/data/tabular/transformation/_k_nearest_neighbors_imputer.py

tests/safeds/data/tabular/transformation/test_k_nearest_neighbors_imputer.py

…puter.py Co-authored-by: Lars Reimann <mail@larsreimann.com>

…ors_imputer.py Co-authored-by: Lars Reimann <mail@larsreimann.com>

SamanHushi · 2024-06-28T10:47:33Z

how should we cover the hash() ?
We don't see a test in discretiser for it where hash() also got used

lars-reimann · 2024-06-28T13:44:43Z

Have a look at how __hash__ was tested for Table: https://github.com/Safe-DS/Stdlib/blob/6fbe5379ae7676906bf8d0f21fe00926d792c60f/tests/safeds/data/tabular/containers/_table/test_hash.py

…uter

LIEeOoNn · 2024-07-01T11:05:21Z

i also added a check if value_to_replace is None we want to replace it with np.nan so the sklearn KNN_Imputer can handle the parameters correctly without throwing an error.
It will still impute values =None with the calculated value!

lars-reimann

Nice work, just two small changes left.

src/safeds/data/tabular/transformation/_k_nearest_neighbors_imputer.py

lars-reimann

Nice contribution, thanks!

## [0.27.0](v0.26.0...v0.27.0) (2024-07-19) ### Features * join ([#870](#870)) ([5764441](5764441)), closes [#745](#745) * activation function for forward layer ([#891](#891)) ([5b5bb3f](5b5bb3f)), closes [#889](#889) * add `ImageDataset.split` ([#846](#846)) ([3878751](3878751)), closes [#831](#831) * add FunctionalTableTransformer ([#901](#901)) ([37905be](37905be)), closes [#858](#858) * add InvalidFitDataError ([#824](#824)) ([487854c](487854c)), closes [#655](#655) * add KNearestNeighborsImputer ([#864](#864)) ([fcdfecf](fcdfecf)), closes [#743](#743) * add moving average plot ([#836](#836)) ([abcf68a](abcf68a)) * add RobustScaler ([#874](#874)) ([62320a3](62320a3)), closes [#650](#650) [#873](#873) * add SequentialTableTransformer ([#893](#893)) ([e93299f](e93299f)), closes [#802](#802) * add temporal operations ([#832](#832)) ([06eab77](06eab77)) * added 'histogram_2d' in TablePlotter ([#903](#903)) ([4e65ba9](4e65ba9)), closes [#869](#869) [#798](#798) * added from_str_to_temporal and continues prediction ([#767](#767)) ([35f468a](35f468a)), closes [#806](#806) [#765](#765) [#740](#740) [#773](#773) * added GRU layer ([#845](#845)) ([d33cb5d](d33cb5d)) * Adds Dropout Layer ([#868](#868)) ([a76f0a1](a76f0a1)), closes [#848](#848) * dark mode for plots ([#911](#911)) ([5447551](5447551)), closes [#798](#798) * easily create a baseline model ([#811](#811)) ([8e1b995](8e1b995)), closes [#710](#710) * get first cell with value other than `None` ([#904](#904)) ([5a0cdb3](5a0cdb3)), closes [#799](#799) * hyperparameter optimization for fnn models ([#897](#897)) ([c1f66e5](c1f66e5)), closes [#861](#861) * implement violin plots ([#900](#900)) ([9f5992a](9f5992a)), closes [#867](#867) * plot decision tree ([#876](#876)) ([d3f81dc](d3f81dc)), closes [#856](#856) * prediction no longer takes a time series dataset only table ([#838](#838)) ([762e5c2](762e5c2)), closes [#837](#837) * raise if `remove_colums` is called with unknown column by default ([#852](#852)) ([8f78163](8f78163)), closes [#807](#807) * regularization strength for logistic classifier ([#866](#866)) ([9f74e92](9f74e92)), closes [#750](#750) * reorders parameters of RangeScaler and makes them keyword-only ([#847](#847)) ([2b82db7](2b82db7)), closes [#809](#809) * replace seaborn with matplotlib for box_plot ([#863](#863)) ([4ef078e](4ef078e)), closes [#805](#805) [#849](#849) * replaced seaborn with matplotlib for correlation_heatmap ([#850](#850)) ([d4680d4](d4680d4)), closes [#800](#800) [#849](#849) ### Bug Fixes * **deps:** bump urllib3 from 2.2.1 to 2.2.2 ([#842](#842)) ([b81bcd6](b81bcd6)), closes [#3122](https://github.com/Safe-DS/Library/issues/3122) [#3363](https://github.com/Safe-DS/Library/issues/3363) [#3122](https://github.com/Safe-DS/Library/issues/3122) [#3363](https://github.com/Safe-DS/Library/issues/3363) [#3406](https://github.com/Safe-DS/Library/issues/3406) [#3398](https://github.com/Safe-DS/Library/issues/3398) [#3399](https://github.com/Safe-DS/Library/issues/3399) [#3396](https://github.com/Safe-DS/Library/issues/3396) [#3394](https://github.com/Safe-DS/Library/issues/3394) [#3391](https://github.com/Safe-DS/Library/issues/3391) [#3316](https://github.com/Safe-DS/Library/issues/3316) [#3387](https://github.com/Safe-DS/Library/issues/3387) [#3386](https://github.com/Safe-DS/Library/issues/3386) * labels of correlation heatmap ([#894](#894)) ([a88a609](a88a609)), closes [#871](#871) * make multi-processing in baseline models more consistent ([#909](#909)) ([fa24560](fa24560)), closes [#907](#907) ### Performance Improvements * improved performance in various methods in `Image` and `ImageList` ([#879](#879)) ([134e7d8](134e7d8))

lars-reimann · 2024-07-19T13:01:50Z

🎉 This PR is included in version 0.27.0 🎉

The release is available on:

v0.27.0
GitHub release

Your semantic-release bot 📦🚀

SamanHushi and others added 8 commits June 21, 2024 14:16

KNN imputer implemenmted

54ec649

modified __init__

ba42201

added tests and change a bit

e80a651

more and better test

36640fd

removed typechecking for init

6450e3d

end of day

83f7d92

wrote all tests and everything working accordingly

a8e9fd9

renamed a test and removed a wrong todo

aa69dce

SamanHushi requested review from lars-reimann, Gerhardsa0, Marsmaennchen221 and sibre28 as code owners June 28, 2024 08:12

SamanHushi linked an issue Jun 28, 2024 that may be closed by this pull request

Add KNearestNeighborsImputer #743

Closed

megalinter-bot added 2 commits June 28, 2024 08:13

style: apply automated linter fixes

8dfb8c4

style: apply automated linter fixes

d4375b7

lars-reimann changed the title ~~feat: 743 add knearestneighborsimputer~~ feat: add KNearestNeighborsImputer Jun 28, 2024

LIEeOoNn and others added 5 commits June 28, 2024 10:42

how should we test the __hash__ function?

054fba2

style: apply automated linter fixes

1c1bfa4

style: apply automated linter fixes

959a250

removed unreachable code

f866aff

Merge branch 'main' into 743-add-knearestneighborsimputer

18a8e62

lars-reimann requested changes Jun 28, 2024

View reviewed changes

SamanHushi and others added 6 commits June 28, 2024 11:52

added missing word in Knn discription

d568a1f

adjusted tests

b704c03

Update src/safeds/data/tabular/transformation/_k_nearest_neighbors_im…

1412a12

…puter.py Co-authored-by: Lars Reimann <mail@larsreimann.com>

Update src/safeds/data/tabular/transformation/_k_nearest_neighbors_im…

f6f1974

…puter.py Co-authored-by: Lars Reimann <mail@larsreimann.com>

Update src/safeds/data/tabular/transformation/_k_nearest_neighbors_im…

9e68c09

…puter.py Co-authored-by: Lars Reimann <mail@larsreimann.com>

Update src/safeds/data/tabular/transformation/_k_nearest_neighbors_im…

7a5a454

…puter.py Co-authored-by: Lars Reimann <mail@larsreimann.com>

SamanHushi and others added 3 commits June 28, 2024 11:58

Update tests/safeds/data/tabular/transformation/test_k_nearest_neighb…

6f5d4ed

…ors_imputer.py Co-authored-by: Lars Reimann <mail@larsreimann.com>

added '_check_bounds' implementation

e436937

added neighbor_count to all tests

ef72b77

LIEeOoNn and others added 2 commits July 1, 2024 12:52

should have 100% conver now and hashing implemented like in SimpleImp…

c4caca7

…uter

style: apply automated linter fixes

21f3d0c

Merge branch 'main' into 743-add-knearestneighborsimputer

64dc4a8

lars-reimann requested changes Jul 2, 2024

View reviewed changes

src/safeds/data/tabular/transformation/_k_nearest_neighbors_imputer.py Outdated Show resolved Hide resolved

src/safeds/data/tabular/transformation/_k_nearest_neighbors_imputer.py Outdated Show resolved Hide resolved

lars-reimann reviewed Jul 2, 2024

View reviewed changes

src/safeds/data/tabular/transformation/_k_nearest_neighbors_imputer.py Show resolved Hide resolved

LIEeOoNn and others added 3 commits July 2, 2024 11:49

added property value_to_replace changed nan into fit and the import also

55d4a71

removed the import of nan into the if statement

3b670ca

style: apply automated linter fixes

3fc7a62

lars-reimann requested changes Jul 2, 2024

View reviewed changes

src/safeds/data/tabular/transformation/_k_nearest_neighbors_imputer.py Outdated Show resolved Hide resolved

LIEeOoNn and others added 2 commits July 2, 2024 12:17

now using var: value_to_replace for correct usage_

489d329

style: apply automated linter fixes

c63833a

lars-reimann approved these changes Jul 2, 2024

View reviewed changes

lars-reimann merged commit fcdfecf into main Jul 2, 2024
10 checks passed

lars-reimann deleted the 743-add-knearestneighborsimputer branch July 2, 2024 10:29

lars-reimann added the released Included in a release label Jul 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add KNearestNeighborsImputer #864

feat: add KNearestNeighborsImputer #864

SamanHushi commented Jun 28, 2024

github-actions bot commented Jun 28, 2024 •

edited

Loading

codecov bot commented Jun 28, 2024 •

edited

Loading

SamanHushi commented Jun 28, 2024

lars-reimann commented Jun 28, 2024 •

edited

Loading

LIEeOoNn commented Jul 1, 2024

lars-reimann left a comment

lars-reimann left a comment

lars-reimann commented Jul 19, 2024

feat: add KNearestNeighborsImputer #864

feat: add KNearestNeighborsImputer #864

Conversation

SamanHushi commented Jun 28, 2024

Summary of Changes

github-actions bot commented Jun 28, 2024 • edited Loading

🦙 MegaLinter status: ✅ SUCCESS

codecov bot commented Jun 28, 2024 • edited Loading

Codecov Report

SamanHushi commented Jun 28, 2024

lars-reimann commented Jun 28, 2024 • edited Loading

LIEeOoNn commented Jul 1, 2024

lars-reimann left a comment

Choose a reason for hiding this comment

lars-reimann left a comment

Choose a reason for hiding this comment

lars-reimann commented Jul 19, 2024

github-actions bot commented Jun 28, 2024 •

edited

Loading

codecov bot commented Jun 28, 2024 •

edited

Loading

lars-reimann commented Jun 28, 2024 •

edited

Loading