Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMA build #593

Merged
merged 3 commits into from
Jan 31, 2018
Merged

Fix CMA build #593

merged 3 commits into from
Jan 31, 2018

Conversation

jdinan
Copy link
Member

@jdinan jdinan commented Jan 30, 2018

Closes #586

James Dinan added 3 commits January 30, 2018 11:52
CMA: Add back uio.h
2729f0a 
Inclusion of uio.h is needed in both the libc and non-libc bindings
cases, since the non-libc case still needs the "struct iovec" type
definition.

Signed-off-by: James Dinan <james.dinan@intel.com>
OFI: Move _GNU_SOURCE up to increase odds it works
555533a 
Signed-off-by: James Dinan <james.dinan@intel.com>
CMA: Move _GNU_SOURCE definition to top-level
0da8783 
Because the CMA transport header depends on _GNU_SOURCE, it won't work
to define it in the header itself (since _GNU_SOURCE needs to be defined
before any system headers are included and transport_cma.h is not
reliably the first header included).  So, move the definiton of
_GNU_SOURCE to config.h and flag an error if it's not defined when
transport_cma.h is included.

Signed-off-by: James Dinan <james.dinan@intel.com>
@jdinan
Copy link
Member Author

jdinan commented Jan 30, 2018 •
edited
Loading

This eliminates the build warnings/errors in my test environments. Need to double-check the Travis logs to ensure the warnings observed in #586 are also resolved.

Update: Travis logs check out. This resolves #586.

@jdinan jdinan merged commit 6ac5116 into Sandia-OpenSHMEM:master Jan 31, 2018
@jdinan jdinan deleted the pr/fix-cma branch February 5, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidozog davidozog davidozog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdinan @davidozog