Skip to content

Commit

Permalink
Reenable the MSVC release builds on GitHub.
Browse files Browse the repository at this point in the history
According to actions/runner-images#10004, the
problems with the Windows runners have been fixed. They prevented
successful runs for release builds.

So this commit reverts 20c1fd8.
  • Loading branch information
Sedeniono committed Jun 22, 2024
1 parent 334e0fb commit e1f2d6c
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/test_msvc_win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,7 @@ jobs:
# in the solution file. In other words, the values do not correspond directly to compiler
# switches but instead to parts of the configuration names from the .sln file.
cpp_version: [C++17, C++20]
# The Windows GitHub runner is broken for release builds. There are crashes in std::mutex
# because they haven't installed the latest Visual C++ Redistributable after updating
# Visual Studio to 17.10. See https://github.com/actions/runner-images/issues/10004
# Until GitHub updates the runner, we simply disable release builds.
buildmode: [Debug]
#buildmode: [Debug, Release]
buildmode: [Debug, Release]

include:
- cpp_version: "C++17 permissive"
Expand Down

0 comments on commit e1f2d6c

Please sign in to comment.