Flexible inputs, second attempt #100
Conversation
nmathewson
force-pushed
the
flexible_serde_v2
branch
from
84d0de4
to
524f2e0
Compare
|
Hi. I'm one of @nmathewson's colleagues. I mostly just wanted to say thanks to @SergioBenitez for engaging with this, to try to help meet our needs. @nmathewson, I'd be happy to help here. Eg, would you like me to read the code in this MR? I did have one question. Why are we calling these methods "lossy"? I hope they aren't really lossy. But I just came in here so maybe I am confused... |
|
I really like this idea, and I'm committed to reviewing/merging this as soon as I free up a bit (in the next few days)! @ijackson Thank you! I chose "lossy" because we lose the true type information in the conversion process. In this comment I show how this is truly a loss and not just a conversion. |
I do agree that when we consider these conversions as applied to individual strings or numbers, they are lossy: When you convert But I wonder whether "lossy" is the right word for the overall feature when applied to an entire configuration in (Edited to add: That said, having this option is more important to me than having the perfect name for this option. :) ) |
SergioBenitez
force-pushed
the
flexible_serde_v2
branch
3 times, most recently
from
7fb9479
to
410852a
Compare
This commit adds `Figment::extract_{inner_}lossy()`, variants of the
existing methods that convert string representations of booleans and
integers into their boolean and integer forms. The original string form
is lost and is not directly recoverable.
Methods that performs the same conversion are added to `Value` types:
* `Value::to_num_lossy()`
* `Value::to_bool_lossy()`
* `Num::to_u128_lossy()`
* `Num::from_str()`
Closes SergioBenitez#97.
Co-authored-by: Sergio Benitez <sb@sergio.bz>
SergioBenitez
force-pushed
the
flexible_serde_v2
branch
from
410852a
to
87d79b9
Compare
|
Published in 0.10.18! Thanks for working with me on this. Fantastic work! |
This is a second attempt to implement the idea of #97.
Instead of changing the default behavior of
impl Deserialize for *, it instead provides newextract_lossyandextract_inner_lossymethods that implement the lossy behavior across the entire figment object.(As an alternative, as discussed on #97, the user might annotate all their booleans and numbers with
deserialize_with. But it can be error-prone to do so, especially if the configuration structure is large and complex.)