Changing GitHub Actions to reflect the GitHub user + updating some references #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding in all recent edits
|
See conversation in #18 |
| @@ -18,18 +18,24 @@ on: | |||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
| permissions: write-all | |||
There was a problem hiding this comment.
Quickly googling ERROR: denied: installation not allowed to Write organization package and the suggestion is to update these permissions to write-all as you already have done - so not sure there, but otherwise everything LGTM
There was a problem hiding this comment.
It's still not working, so I need to work more on this!
|
With this change do you think we even require a doc for #18 ? My original motivation was so any future developers knew how to change the token if I was not working on the project anymore, but that might no longer be an issue |
|
That's my hope! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done:
secrets.GH_TOKENto the automaticsecrets.GITHUB_TOKENseshat-global-history-databank/seshatto a variable${{ github.actor }}/seshatinstead, which allows for forks to run builds + tests automatically as well