Bump minimum RuboCop version #210
Conversation
|
Actually testing against RuboCop 0.90.0 reveals that we don't support it (despite our gemspec saying we do). #207 doesn't work as RuboCop 1.6 was the first version to define However, using RuboCop 1.6.0 still has over 100 test failures. I ran the test suite against every RuboCop version, and the point where it crosses over into compatibility is around RuboCop
Based on that, I propose that we change the minimum RuboCop version to reflect actual compatibility (rather than try to backport compatibility). -spec.add_runtime_dependency("rubocop", ">= 0.90.0")
+spec.add_runtime_dependency("rubocop", ">= 1.45.1") |
.github/workflows/ci.yml
Outdated
| @@ -11,15 +11,20 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ruby: ["2.7", "3.0", "3.1", "3.2"] | |||
| name: Test Ruby ${{ matrix.ruby }} | |||
| ruby: ["2.7", "3.0", "3.1", "3.2", "3.3"] | |||
There was a problem hiding this comment.
Let's drop 2.7 since it's EOL?
.github/workflows/ci.yml
Outdated
| @@ -33,7 +38,7 @@ jobs: | |||
| - name: Set up Ruby | |||
| uses: ruby/setup-ruby@v1 | |||
| with: | |||
| ruby-version: 3.2 | |||
| ruby-version: 3.3 | |||
There was a problem hiding this comment.
Not a blocker, but we should be able to switch to the 'centralized' approach, similiar to https://github.com/Shopify/ruby-lsp/pull/1830/files
|
@andyw8 I'll address both your Ruby version related comments in a separate PR 👍 |
sambostock
changed the title
This ensures we're compatible with the minimum RuboCop version we claim in `rubocop-sorbet.gemspec`. This approach is copied from `rubocop-shopify`.
This change reflects the actual current compatibility of the gem, as versions prior to this one do not work.
sambostock
force-pushed
the
test-against-minimum-rubocop
branch
from
1b8c686
to
9bf7b93
Compare
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This PR originally just added the minimum RuboCop version to the CI matrix, but it was discovered that that version doesn't work, so in now also bumps it.
This bumps the minimum RuboCop version to 1.45.1, to reflect actual compatibility.
It also adds the minimum RuboCop version to the CI matrix. This ensures we're compatible with the minimum RuboCop version we claim in
rubocop-sorbet.gemspec.This approach is copied from
rubocop-shopify.