Eth2 Light Client #582
Eth2 Light Client #582
Conversation
Co-authored-by: Vincent Geddes <vincent@snowfork.com>
| /// Best available header to switch finalized head to if we see nothing else | ||
| #[pallet::storage] | ||
| pub(super) type BestValidUpdate<T: Config> = | ||
| StorageValue<_, Option<LightClientUpdate>, ValueQuery>; // TODO: Maybe I should use OptionQuery here instead of Option? |
There was a problem hiding this comment.
Yeah, OptionQuery would work better here to simplify later queries.
There was a problem hiding this comment.
I'll change this when I call the light from the relayer, if that's OK? I'd like to see how it makes a difference, practically, by calling the light client from the relayer with ValueQuery first and then see how OptionQuery simplifies it.
|
@vgeddes @alistair-singh @musnit I think this is ready for review, even if there are still some unfinished parts. I would like to open smaller PRs from here on out. |
| eth2_ssz_types = { version = "0.2.1" } | ||
| tree_hash = { version = "0.4.0" } | ||
| tree_hash_derive = { version = "0.4.0" } | ||
| milagro_bls = { git = "https://github.com/sigp/milagro_bls", tag = "v1.4.2" } |
There was a problem hiding this comment.
This lib has an std feature, which we should not enable by default.
| milagro_bls = { git = "https://github.com/sigp/milagro_bls", tag = "v1.4.2" } | |
| milagro_bls = { git = "https://github.com/sigp/milagro_bls", tag = "v1.4.2", default-features = false } |
| "sp-std/std", | ||
| "snowbridge-core/std", | ||
| "snowbridge-ethereum/std", | ||
| ] |
There was a problem hiding this comment.
Need to add the std feature of milagro_bls here. So that when we want to compile the code to native machine code (not WASM) we can enable std feature and allow linking to the core std library.
| codec = { version = "2.2.0", package = "parity-scale-codec", default-features = false, features = ["derive"] } | ||
| scale-info = { version = "1.0", default-features = false, features = ["derive"] } | ||
| hex = { package = "rustc-hex", version = "2.1.0", default-features = false } | ||
| hex-literal = { version = "0.3.1", optional = true } |
There was a problem hiding this comment.
hex_literal is only being used in test modules, so you remove it from this section (It doesn't support no_std so will cause problems otherwise). I see it is already listed under dev-dependencies, so that's good.
| serde = { version = "1.0.130", optional = true } | ||
| codec = { version = "2.2.0", package = "parity-scale-codec", default-features = false, features = ["derive"] } | ||
| scale-info = { version = "1.0", default-features = false, features = ["derive"] } | ||
| hex = { package = "rustc-hex", version = "2.1.0", default-features = false } |
There was a problem hiding this comment.
This dependency seems to be unused.
| name = "snowbridge-ethereum-beacon-light-client" | ||
| description = "Snowbridge Beacon Light Client Pallet" | ||
| version = "0.0.1" | ||
| edition = "2021" |
There was a problem hiding this comment.
The reason why the build is still failing after adding edition 2021 is because the github workflow doing the build is using an older version of the rust toolchain.
This commit is the version I used for edition 2021 in the v0.9.17 PR that is not yet merged in.
7167fdc
There was a problem hiding this comment.
Thanks Alistair! 👍 So the edition 2021 should work after the rust toolchain upgrade? I've started updating the other crate's editions too: https://github.com/Snowfork/snowbridge/pull/605/files
|
Dependent on #591 to update Rust toolchain for the Cargo edition |
|
Closing in favour of #610. |
Starts adding the Eth2 light client scaffolding in a new pallet.