Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LD scripts syntax #502

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

renatoalencar
Copy link
Contributor

Although this syntax is supported by newer versions of GNU ld, it looks it's not supported some older releases. This seems to fix the problem and works for both older and newer versions.

Here's my version of ld, which is still the newer version for Fedora 35 https://src.fedoraproject.org/rpms/binutils

GNU ld version 2.37-10.fc35
Copyright (C) 2021 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.

I have tested on the current trunk for GNU binutils and it seems to work tough, which is the same minor version.

GNU ld (GNU Binutils) 2.37.50.20211207
Copyright (C) 2021 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.

@hannesm
Copy link
Contributor

hannesm commented Dec 9, 2021

Thanks for your investigation and fix. @dinosaure @TheLortex could we get a 0.6.9 release with this (and #495) before the big merge of #494? I stumbled upon this issue in mirage/mirage-net-solo5#37 where OCaml-CI uses alpine-3.15.

@dinosaure dinosaure merged commit 77432fe into Solo5:master Dec 13, 2021
@dinosaure
Copy link
Collaborator

Thanks, let's do a minor release for OpenBSD.

@renatoalencar renatoalencar deleted the fix-lds-syntax branch December 13, 2021 12:45
This was referenced Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants