-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[review] run_taskのコンテナスペックを選択制に変更 #21
[review] run_taskのコンテナスペックを選択制に変更 #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
みました。リファクタコメントだけ
.github/workflows/rspec.yml
Outdated
matrix: | ||
ruby: ["3.0", "3.1", "3.2"] | ||
steps: | ||
- uses: actions/checkout@v3.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v4 出てませんでした?
- uses: actions/checkout@v3.5.3 | |
- uses: actions/checkout@v4 |
spec/spec_helper.rb
Outdated
PROJECT_ROOT = File.expand_path(File.join(File.dirname(__FILE__), '..')) | ||
$LOAD_PATH << File.join(PROJECT_ROOT, 'lib') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要では?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rspec --init するといい感じのファイルを生成してくれそう。
https://github.com/rspec/rspec-metagem#setup
No description provided.