[review] Use Rails.application.config_for #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aki77
commented
Nov 6, 2023
| @@ -70,7 +70,7 @@ def input_overrides_json | |||
| end | |||
|
|
|||
| def convert_container_type | |||
| CONTAINER_TYPES[@container_type] | |||
| @container_type ? CONTAINER_TYPES.fetch(@container_type) : nil | |||
There was a problem hiding this comment.
おかしな値指定した場合は、黙ってnilになるのではなくエラーでコケてほしい。
aki77
commented
Nov 6, 2023
| @@ -48,26 +48,24 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe '#parse' do | |||
| describe '.convert' do | |||
There was a problem hiding this comment.
Rails.application.config_forのパース処理自体をテストするのは無駄なので、パース結果からの変換のみをテストするように見直し。
aki77
commented
Nov 6, 2023
Closed
interu
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.