[review] メンテナンス画面判定にもrequest.remote_ipを利用するように #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aki77
commented
Nov 7, 2023
lib/sg_fargate_rails/config.rb
Outdated
| @@ -1,13 +1,15 @@ | |||
| module SgFargateRails | |||
| class Config | |||
| attr_reader :proxy_ip_addresses | |||
| attr_accessor :middleware_enabled_rails_envs | |||
There was a problem hiding this comment.
決め打ちは何かと不便なので、デフォルトの挙動は基本そのままで設定可能としたけど、envを設定するのではなく有効無効を設定するだけで良さそうだったかも。
attr_accessor :middleware_enabled
def initialize
self.middleware_enabled = !Rails.env.development? && !Rails.env.test?
end
kzkn
approved these changes
Nov 8, 2023
lib/sg_fargate_rails/config.rb
Outdated
| @@ -1,13 +1,15 @@ | |||
| module SgFargateRails | |||
| class Config | |||
| attr_reader :proxy_ip_addresses | |||
| attr_accessor :middleware_enabled_rails_envs | |||
middleware_enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.