Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast-json-patch unusable with node-inspector #117

Closed
ghost opened this issue Aug 2, 2016 · 4 comments
Closed

fast-json-patch unusable with node-inspector #117

ghost opened this issue Aug 2, 2016 · 4 comments

Comments

@ghost
Copy link

ghost commented Aug 2, 2016

I'm trying to use fast-json-patch in my webserver. As happens quite often, errors occur, and I usually debug them using node-inspector.

However, node-inspector simply won't work with fast-json-patch. The error I get is this:

Network.loadResourceForFrontend failed. Error: ENOENT: no such file or directory, open '/path/to/node_modules/fast-json-patch/src/json-patch-duplex.js.map'

Is there a way to fix this so that node-inspector will not crash?

@MarkHerhold
Copy link
Contributor

I don't think this module has anything to do with your generated .map
files.

On Tue, Aug 2, 2016, 7:19 PM Karl Giesing notifications@github.com wrote:

I'm trying to use fast-json-patch in my webserver. As happens quite often,
errors occur, and I usually debug them using node-inspector.

However, node-inspector simply won't work with fast-json-patch. The error
I get is this:

Network.loadResourceForFrontend failed.
Error: ENOENT: no such file or directory, open
'/path/to/node_modules/fast-json-patch/src/json-patch-duplex.js.map'

Is there a way to fix this so that node-inspector will not crash?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#117, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AEtMTDnV0BH1cbvlatXVc-uDsVuUxC4Eks5qb9CPgaJpZM4JbJdT
.

@ghost
Copy link
Author

ghost commented Aug 3, 2016

It is the job of whoever minified/transpiled the code to generate the source map file. That would be you, or someone else who maintains this module.

If there is no source map file, then you need to remove the comments that claim there is one. These comments are found at the bottom of json-patch.js and json-patch-duplex.js (they are the last lines of those files).

EDIT: This is the line that is causing my specific issue. It is the last line of json-patch-duplex.js:

//# sourceMappingURL=json-patch-duplex.js.map

@tomalec
Copy link
Collaborator

tomalec commented Sep 8, 2016

Seems link regression of #55 @ugieska are you fine with removing this link at all? (especially from non-minified versions)

tomalec added a commit that referenced this issue Sep 8, 2016
Remove OriginalEvent global (#120)

Remove source map links from compiled js #117
@tomalec
Copy link
Collaborator

tomalec commented Sep 8, 2016

//# sourceMappingURL=json-patch-duplex.js.map

Was removed in 1.0.1

Feel free to reopen in case you do not like such solution.

@tomalec tomalec closed this as completed Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants