Adds Support for Swift 5 #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for Swift 5 as well as removing warnings when executing `swift build` on a project generated through `swift package generate-xcodeproj`
This commit updates the podspec to include support for Swift 5 as well as using the latest version of Stencil that also supports Swift 5.
|
Thank you for your contribution. I know it's been a while, and in the mean time, this has been superseded by #127, which (amongst other things) adds support for Swift 5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Internal Change
It's been bothering me that when I use Swift 5 with StencilSwiftKit, a few warnings pop up due to outdated usages of older Swift APIs. By updating this library to support Swift 5, those warnings will go away. I also fixed the warning for redundant usages of
publicwithinpublicextensions.Since Stencil no longer supports versions of Swift earlier than 4.1, I updated the library to do the same by dropping support as well.