Fix version for Komondor #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djbe this is a big issue for Sourcery |
|
Ugh this is annoying TBH, Komondor should release a new version with those dependencies hidden again 🤦 But then again, should we be hiding dependencies like Komondor ourselves as well? What about testing dependencies like Spectre (from Stencil)? Although Komondor is definitely the biggest issue, because it includes quite a lot of big packages. |
djbe
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Komondor had a release for v.1.1.4 where it added unnecessary dependencies that will only be used in Komondor's development process.
It would be great if we could minimize dependencies to avoid SPM conflicts by not updating Komondor to v1.1.4.
Right now, Sourcery as a SPM plugin is facing a conflict because of this.