Resolve relative sass_root paths earlier #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wryk
force-pushed
the
fix/resolve-relative-sass-path-earlier
branch
from
59d2803
to
f82915f
Compare
wryk
force-pushed
the
fix/resolve-relative-sass-path-earlier
branch
from
f82915f
to
2684cf3
Compare
|
I'll look later this week, no immediate feedback except: i'd still start with a ".sass" check :) |
|
Yeah sorry, I ignored this part on purpose and I took the conservative choice to only rollback SassCssCompiler. |
|
I mande a PR on your PR with small change suggestions :) |
…rlier Resolve relative sass_root paths earlier SymfonyCasts#65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert SassCssCompiler before #64. Supports relative paths by resolving/prefixing them at extension loading. I don't know if it should be implemented this way (it feels hacky?) but I don't see how it could be better.
What do you think of this change @smnandre ?
Tests are missing because I don't know enough how asset-mapper works to design an integration test for an AssetCompiler. Testing the builder instead would be even more work for me because my dev env doesn't supports the default sass binary from the bundle.
I'll not have more time in the next weeks to work on it, feel free to modify this PR as much as you want.