Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the requirement to set a provider when setting config/secrets through the controller and there's only one provider #1701

Open
alecthomas opened this issue Jun 7, 2024 · 5 comments
Assignees

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Jun 7, 2024

eg. in production there's (currently) only ASM/DB, so it's redundant to have to specify --asm

Instead the cluster would be required to start with a flag specifying the writing resolve, so the client would not make any decisions.

This change should allow the controller to support multiple providers for reading but only one for writing, as usual, but the controller is the one that selects the writer at startup. This would also remove the types for setting the provider over gRPC. The client will still need these flags for the local case, but for the gRPC path it would be able to skip requiring the user to set a writer.

@github-actions github-actions bot added the triage Issue needs triaging label Jun 7, 2024
@ftl-robot ftl-robot mentioned this issue Jun 7, 2024
@alecthomas alecthomas added the next Work that will be be picked up next label Jun 10, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jun 10, 2024
@alecthomas alecthomas added next Work that will be be picked up next and removed next Work that will be be picked up next labels Jun 10, 2024
@jonathanj-square jonathanj-square self-assigned this Jul 1, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jul 1, 2024
@jonathanj-square
Copy link
Contributor

jonathanj-square commented Jul 1, 2024

@alecthomas I am not clear on "Instead the cluster would be required to start with a flag specifying the writing resolve, so the client would not make any decisions." - my best guess is...

The cluster needs to expose a flag to determine which config / secret provider to use as default, in the event that there are multiple, so the client is never required to supply a provider when setting a config or secret. Is that anywhere near what you meant?

@alecthomas
Copy link
Collaborator Author

That's exactly correct. Instead of the client controlling what writer to use, the controller does.

@alecthomas
Copy link
Collaborator Author

This is not high priority though, let me remove it from next.

@alecthomas
Copy link
Collaborator Author

Actually let's do some prioritisation in the sync today.

jonathanj-square added a commit that referenced this issue Jul 1, 2024
selects the sole provider when no key is supplied and there is exactly 1 provider.
jonathanj-square added a commit that referenced this issue Jul 1, 2024
selects the sole provider when no key is supplied and there is exactly 1 provider.
jonathanj-square added a commit that referenced this issue Jul 2, 2024
selects the sole provider when no key is supplied and there is exactly 1 provider.
@alecthomas
Copy link
Collaborator Author

@jonathanj-square I'm going to include this in some general config refactoring I'm doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants