Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some screenreader support that had upset the linter #2696

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

deniseli
Copy link
Contributor

@deniseli deniseli commented Sep 16, 2024

Removes the 2 sr-only elements that caused lint errors in #2676. The changes suggested by the linter weren't really quite exactly correct either, and we aren't formally supporting screenreaders in the console anyway, so we can just remove it.

This was referenced Sep 16, 2024
@deniseli deniseli marked this pull request as ready for review September 16, 2024 19:57
@deniseli deniseli requested review from alecthomas and a team as code owners September 16, 2024 19:57
@deniseli deniseli requested review from jonathanj-square and wesbillman and removed request for a team September 16, 2024 19:57
@deniseli deniseli merged commit 4ab53cc into main Sep 16, 2024
92 checks passed
@deniseli deniseli deleted the dli/clean branch September 16, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants