Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Reading public Records/Protocols when in a delegated state #899

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Sep 11, 2024

When in a delegated state, allow the user to read/query/subscribe to public records and protocols even if they don't have an explicit permission for them.

These query/read/subscribe messages will be AUTHORED by the Delegated DID instead of the Connected DID.
If attempting to update/import/etc these records they will fail due to lack of permissions.

Ultimately read-only actions would be moved to a different part of the API, reverting much of this code:
#898


Resolved vulnerability issues with pnpm audit --fix

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: b40a843

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web5/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 11, 2024

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 5

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts
📄 File: ./packages/crypto/src/utils.ts
⚠️ extractor:typedoc:missing-docs: CryptoUtils (Variable) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomPin (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomUuid (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomBytes (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.getJoseSignatureAlgorithmFromPublicKey (Property) does not have any documentation.

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-09-11T16:55:55Z b40a843

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.45%. Comparing base (57803fa) to head (b40a843).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files         117      117           
  Lines       33363    33408   +45     
  Branches     2693     2697    +4     
=======================================
+ Hits        31178    31223   +45     
  Misses       2146     2146           
  Partials       39       39           
Components Coverage Δ
agent 87.49% <ø> (ø)
api 99.60% <100.00%> (+<0.01%) ⬆️
common 98.68% <ø> (ø)
credentials 94.95% <ø> (ø)
crypto 93.79% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.42% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.42% <ø> (ø)
user-agent 96.57% <ø> (ø)

@LiranCohen LiranCohen merged commit 9f0a128 into main Sep 11, 2024
35 checks passed
@LiranCohen LiranCohen deleted the lirancohen/public-records branch September 11, 2024 17:14
This was referenced Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants