Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use importlib.resources and better cache control #40

Merged
merged 6 commits into from
Sep 11, 2021
Merged

Use importlib.resources and better cache control #40

merged 6 commits into from
Sep 11, 2021

Conversation

mariosasko
Copy link
Contributor

This PR:

  • uses importlib.resources to load files from inside a package (more info on this change can be found here)
  • changes the default model cache directory from path/to/package/models to ~/.cache/spacy_udpipe_models and allows users to specify a different cache directory via environment variables or by passing a different models_dir to spacy_udpipe.download.

@mariosasko mariosasko changed the title Improvements Use importlib.resources and better cache control Aug 21, 2021
@mariosasko mariosasko marked this pull request as ready for review August 21, 2021 19:17
@asajatovic asajatovic added the enhancement New feature or request label Sep 11, 2021
@asajatovic asajatovic merged commit a38cd1e into master Sep 11, 2021
@osma osma mentioned this pull request Apr 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajatovic asajatovic asajatovic approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariosasko @asajatovic