feat: Added complete Language support for Spanish, French & German #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TangoBeee
reviewed
Oct 3, 2024
app/src/main/java/me/tangobee/weathernaut/constants/WeatherConstants.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/me/tangobee/weathernaut/ui/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
|
Additionally, the language is reset when the user changes their language and opens the app. |
Regarding that, I will use DataStore and will update the language as required. Will update you once it's done |
|
@singhDevs Sure, take your time. |
|
@singhDevs If you’d prefer not to resolve those issues, that’s okay! I can take care of them after merging this PR. |
…r spinner language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @TangoBeee ,
As discussed, I have added complete Language support for Spanish, French and German. If you need any support, feel free to reach me out. Attached are some screenshots for your reference.
#9