Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Create Issue & PR template #108

Merged
merged 5 commits into from
Feb 20, 2022
Merged

[feat] Create Issue & PR template #108

merged 5 commits into from
Feb 20, 2022

Conversation

geeneve
Copy link
Member

@geeneve geeneve commented Feb 20, 2022

๐ŸŒˆ PR ์š”์•ฝ / Linked Issue

์ด์Šˆ ํ…œํ”Œ๋ฆฟ, PR ํ…œํ”Œ๋ฆฟ ์ถ”๊ฐ€ ๋ฐ ์ˆ˜์ •
close #106

๐Ÿ“Œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • PR ํ…œํ”Œ๋ฆฟ ๋ณ€๊ฒฝ

    • ์ด PR์€ ๋ณ€๊ฒฝ๋œ ํ…œํ”Œ๋ฆฟ์œผ๋กœ ์ž‘์„ฑํ•ด ๋ณด์•˜์Šต๋‹ˆ๋‹ค ใ…‹

  • ISSUE ์„ ํƒ์ฐฝ
    image

  • feature
    image
    (์ž๋™์œผ๋กœ ์—ฐ๊ฒฐ๋˜๋Š” feature ๋ผ๋ฒจ..!)

  • fix
    image

  • refactor
    image

โœ… PR check list

1. ์ œ๋ชฉ ์–‘์‹ ์ค€์ˆ˜ ํ™•์ธ

[feat] Create Issue & PR template

2. ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘๋™ ์Šคํฌ๋ฆฐ์ƒท

npm run mocha

  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ๊ณ ์น˜๊ณ  ๋‚˜๋ฉด ์Šคํฌ๋ฆฐ์ƒท ์ฒจ๋ถ€ํ•˜์ž!

โœ… After merge check list

1. ๋ฆด๋ฆฌ์ฆˆ ๋…ธํŠธ ๋ณ€๊ฒฝ

๋ฆด๋ฆฌ์ฆˆ ๋…ธํŠธ To Do์—์„œ Done์œผ๋กœ ์˜ฎ๊ธฐ๊ธฐ

2. ๋ธŒ๋žœ์น˜ ์‚ญ์ œ

@geeneve geeneve added ๐Ÿ€ feature ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์ถ”๊ฐ€ 3๏ธโƒฃ priority: low ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ labels Feb 20, 2022
@geeneve geeneve added this to the v1.0.3 milestone Feb 20, 2022
@geeneve geeneve self-assigned this Feb 20, 2022
seohyun-106
seohyun-106 approved these changes Feb 20, 2022
View reviewed changes
Copy link
Contributor

@seohyun-106 seohyun-106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ž๋™์œผ๋กœ ๋ผ๋ฒจ ๋‹ฌ๋ฆฌ๋Š”๊ฑฐ ๋Œ€๋ฐ• ใ„ท ใ„ท ์ž˜๋จน๊ฒ ์Šด๋‹ค ~!
๐Ÿง

.github/ISSUE_TEMPLATE/refactor.md
@@ -0,0 +1,17 @@
---
name: ๐Ÿง refactor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„์˜ค ใ…‹ใ…‹

@holmir97 holmir97 merged commit a7446c6 into develop Feb 20, 2022
@holmir97 holmir97 deleted the feat/create-template branch February 20, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seohyun-106 seohyun-106 seohyun-106 approved these changes

@holmir97 holmir97 Awaiting requested review from holmir97

Assignees

@geeneve geeneve

Labels
3๏ธโƒฃ priority: low ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ ๐Ÿ€ feature ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์ถ”๊ฐ€
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.

[feat] Create Issue & PR template
3 participants
@geeneve @seohyun-106 @holmir97