[refactor] Change database to MongoDB #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor/switch database from postgreSQL to MongoDB
seohyun-106
approved these changes
Mar 3, 2022
| }, | ||
| }); | ||
| const review = await Review.findById( | ||
| new mongoose.Types.ObjectId(reviewId) |
| await review.save(); | ||
| // snake to camel | ||
| const originReview = keysToCamel(review); | ||
| const camelReview = keysToCamel(originReview.Doc); |
| if (!review) { | ||
| return constant.WRONG_REQUEST_VALUE; | ||
| return constant.DB_NOT_FOUND; |
| @@ -412,7 +412,7 @@ const deleteReviewController = async (req: Request, res: Response) => { | |||
| res, | |||
| returnCode.BAD_REQUEST, | |||
| false, | |||
| "존재하지 않는 Review입니다." | |||
| "존재하지 않거나 삭제된 Review입니다." | |||
geeneve
approved these changes
Mar 3, 2022
src/controller/auth.ts
Outdated
| @@ -70,7 +70,7 @@ const getEmailController = async (req: Request, res: Response) => { | |||
| { isValid: true } | |||
| ); | |||
| } catch (err) { | |||
| slack.slackWebhook(req, err.message); | |||
| // slack.slackWebhook(req, err.message); | |||
There was a problem hiding this comment.
이거 내가 작업할 때 슬랙 안뜨게할려고 주석한건데 다시 풀자!!
src/controller/book.ts
Outdated
| @@ -70,7 +70,7 @@ const postBookController = async (req: Request, res: Response) => { | |||
| resData | |||
| ); | |||
| } catch (err) { | |||
| slack.slackWebhook(req, err.message); | |||
| // slack.slackWebhook(req, err.message); | |||
| @@ -0,0 +1,62 @@ | |||
| import _ from "lodash"; | |||
There was a problem hiding this comment.
이 파일 원래 js여서 급하게 ts로 바꾼건디 파라미터랑 함수에 타입 지정 해야겠다 나중에
src/middleware/authMiddleware.ts
Outdated
|
|
||
| // console.log(decoded.user.id); | ||
|
|
||
| // 정상작동 |
| reviewSt: 2, | ||
| finishSt: false, | ||
| }); | ||
| const review = await Review.create( |
| reviews.map(async function (review) { | ||
| // snake to camel | ||
| const originReview = keysToCamel(review); | ||
| const camelReview = keysToCamel(originReview.Doc); |
There was a problem hiding this comment.
Doc이 뭔가요??
아 글구 이 부분 arrow function으로 바꾸자!
|
12일에 거친 100커밋 잘 보고 갑니다 ... Good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈 PR 요약 / Linked Issue
PostgreSQL -> MongoDB
close #115 #114 #113 #112
📌 변경 사항
모든 service 로직 수정
미들웨어 수정
library 추가
controller 수정
✅ PR check list
1. 제목 양식 준수 확인
[feat] PR title
2. 테스트 코드 작동 스크린샷
npm run mocha✅ After merge check list
1. 릴리즈 노트 변경
릴리즈 노트 To Do에서 Done으로 옮기기
2. 브랜치 삭제