Feat/login api #15
Merged
Feat/login api #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seohyun-106
added
🍀 feature
geeneve
approved these changes
Jan 12, 2022
| const postLoginController = async (req: Request, res: Response) => { | ||
| try { | ||
| const { email, password } = req.body; | ||
| const data = await authService.postLoginService(email, password); |
holmir97
approved these changes
Jan 12, 2022
| const postLoginController = async (req: Request, res: Response) => { | ||
| try { | ||
| const { email, password } = req.body; | ||
| const data = await authService.postLoginService(email, password); |
There was a problem hiding this comment.
파라미터로 req.body 한번에 보내도록 통일하겠습니다!
| "비밀번호가 일치하지 않습니다." | ||
| ); | ||
| } else { | ||
| const { nickname, token } = data; |
| } | ||
| }; | ||
| const authController = { | ||
| postSignupController, |
| @@ -0,0 +1,8 @@ | |||
| import express from "express"; | |||
| import authController from "../controller/auth"; | |||
There was a problem hiding this comment.
import 시엔 항상 주석으로 description을 달아주세요!
| import index from "../config"; | ||
| import constant from "../library/constant"; | ||
| import isEmail from "validator/lib/isEmail"; | ||
|
|
| const emailExist = await User.findAll({ | ||
| where: { | ||
| email, | ||
| }, |
There was a problem hiding this comment.
find 쿼리시에는 항상 is_delete 를 포함하여 where절을 걸어주세요
|
|
||
| // nickname이 이미 존재할 때 | ||
| const nicknameExist = await User.findAll({ | ||
| where: { |
| } | ||
|
|
||
| // 존재하지 않는 이메일 | ||
| const user = await User.findOne({ where: { email: email } }); |
| // 존재하지 않는 이메일 | ||
| const user = await User.findOne({ where: { email: email } }); | ||
| if (!user) { | ||
| return -2; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR check list
🌈 PR 요약
📌 변경 사항
constant.tsLinked Issue
close #10
close #11