Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get review api #42

Merged
merged 1 commit into from
Jan 14, 2022
Merged

feat: get review api #42

merged 1 commit into from
Jan 14, 2022

Conversation

seohyun-106
Copy link
Contributor

@seohyun-106 seohyun-106 commented Jan 14, 2022

✅ PR check list

  • commit message가 적절한지 확인해주세요.
  • 마지막으로 Coding Convention을 준수했는지 확인해주세요.
  • 적절한 branch로 요청했는지 확인해주세요.
  • Assignees, Label을 붙여주세요.
  • 가능한 이슈를 Link 해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

  • 독서기록 get api임다
  • 기획에 따라서 책 정보 관련 Responsebody가 수정될 수도 있슴다
  • 독서완료일 때만 쓰는 api가 아니니까 message나 설명에 '독후감'이라는 단어는 수정할 계획임다

📌 변경 사항

  • getReviewService, getReviewController, router 추가

Linked Issue

close #41

@seohyun-106 seohyun-106 added 🍀 feature 새로운 기능 추가 1️⃣ priority: high 우선순위 높음 labels Jan 14, 2022
@seohyun-106 seohyun-106 self-assigned this Jan 14, 2022
Copy link
Member

@geeneve geeneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좀 치네요 ㅋ

Copy link
Member

@holmir97 holmir97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넘모 잘하고~

@holmir97 holmir97 merged commit bb22089 into develop Jan 14, 2022
@holmir97 holmir97 deleted the feat/getReview-api branch January 14, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ priority: high 우선순위 높음 🍀 feature 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants