Feat/get user email api #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seohyun-106
approved these changes
Jan 15, 2022
| */ | ||
| const getEmailController = async (req: Request, res: Response) => { | ||
| try { | ||
| const resData: number = await authService.getEmailService(req.body.email); |
There was a problem hiding this comment.
오 resData도 형식 지정 .. 저도 일케 해보겠슴다 .. 🤨🤨🤨
| return constant.EMAIL_ALREADY_EXIST; | ||
| } | ||
|
|
||
| return constant.SUCCESS; |
There was a problem hiding this comment.
아 맞다 이거 .. 근데 요 상수값은 controller에서는 안쓰는데 클린코드를 위해 사용하는건가여? 🤨🤨🤨
seohyun-106
approved these changes
Jan 15, 2022
src/controller/auth.ts
Outdated
| * @route GET /auth/email | ||
| * @access public | ||
| * @err 1. 필요한 값이 없을 때 | ||
| * 2. 이메일 형식이 올바르지 않을 때 |
There was a problem hiding this comment.
에러? 🧐 에러? 🧐 에러? 🧐 에러? 🧐
src/controller/auth.ts
Outdated
| * @access public | ||
| * @err 1. 필요한 값이 없을 때 | ||
| * 2. 이메일 형식이 올바르지 않을 때 | ||
| * 3. 이메일이 이미 존재할 때 |
There was a problem hiding this comment.
에러? 🧐 에러? 🧐 에러? 🧐 에러? 🧐
seohyun-106
reviewed
Jan 15, 2022
src/controller/auth.ts
Outdated
| returnCode.OK, | ||
| "올바른 형식이 아닙니다.", | ||
| true, | ||
| { isUnique: false } |
There was a problem hiding this comment.
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
seohyun-106
reviewed
Jan 15, 2022
src/controller/auth.ts
Outdated
| returnCode.OK, | ||
| "이미 사용 중인 이메일입니다.", | ||
| true, | ||
| { isUnique: false } |
There was a problem hiding this comment.
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
seohyun-106
reviewed
Jan 15, 2022
src/controller/auth.ts
Outdated
| returnCode.OK, | ||
| "사용할 수 있는 이메일입니다.", | ||
| true, | ||
| { isUnique: true } |
There was a problem hiding this comment.
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
유니크?? 유니클🧐로 인가요? 🧐
holmir97
approved these changes
Jan 15, 2022
| */ | ||
| const getEmailController = async (req: Request, res: Response) => { | ||
| try { | ||
| const resData: number = await authService.getEmailService(req.body.email); |
src/controller/auth.ts
Outdated
| returnCode.OK, | ||
| "올바른 형식이 아닙니다.", | ||
| true, | ||
| { isUnique: false } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR check list
🌈 PR 요약
📌 변경 사항
Linked Issue
close #48