Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/nickname api #51

Merged
merged 4 commits into from
Jan 15, 2022
Merged

Feat/nickname api #51

merged 4 commits into from
Jan 15, 2022

Conversation

seohyun-106
Copy link
Contributor

✅ PR check list

  • commit message가 적절한지 확인해주세요.
  • 마지막으로 Coding Convention을 준수했는지 확인해주세요.
  • 적절한 branch로 요청했는지 확인해주세요.
  • Assignees, Label을 붙여주세요.
  • 가능한 이슈를 Link 해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

  • 유저의 닉네임이 유효한 (중복되지 않고, 형식에 맞는) 닉네임인지 확인

📌 변경 사항

  • /auth/nickname 라우트 추가
  • getNicknameService, Controller 추가

Linked Issue

close #49

@seohyun-106 seohyun-106 added 🍀 feature 새로운 기능 추가 1️⃣ priority: high 우선순위 높음 labels Jan 15, 2022
@seohyun-106 seohyun-106 self-assigned this Jan 15, 2022
@@ -51,6 +51,7 @@ const getMyInfoController = async (req: Request, res: Response) => {
const patchImgController = async (req: Request, res: Response) => {
try {
const img = req.file.location ? req.file.location : null;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧐🧐🧐🧐🧐🧐🧐🧐🧐🧐🧐🧐🧐🧐🧐🧐🧐🧐 이게 구분이 필요한 만큼 중요하게 다루어져야 하는 건가?????? 🧐🧐 잘 모르겠 🧐 어서요...🧐?

@seohyun-106 seohyun-106 merged commit 656fcfb into develop Jan 15, 2022
@seohyun-106 seohyun-106 deleted the feat/nickname-api branch January 15, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ priority: high 우선순위 높음 🍀 feature 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] feat nickname api
3 participants