Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/question list #53

Merged
merged 4 commits into from
Jan 15, 2022
Merged

Feat/question list #53

merged 4 commits into from
Jan 15, 2022

Conversation

holmir97
Copy link
Member

✅ PR check list

  • commit message가 적절한지 확인해주세요.
  • 마지막으로 Coding Convention을 준수했는지 확인해주세요.
  • 적절한 branch로 요청했는지 확인해주세요.
  • Assignees, Label을 붙여주세요.
  • 가능한 이슈를 Link 해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

질문리스트 조회 api

📌 변경 사항

브랜치명에 오타가 조금 있지만 사소합니다 😁

Linked Issue

close #52

@holmir97 holmir97 added 🍀 feature 새로운 기능 추가 1️⃣ priority: high 우선순위 높음 labels Jan 15, 2022
@holmir97 holmir97 self-assigned this Jan 15, 2022
return constant.WRONG_REQUEST_VALUE;
}

return review.question_list;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ 안에 넣어주세요 ㅋ.ㅋ }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정요 {fix: ㅋ.ㅋ}

return constant.WRONG_REQUEST_VALUE;
}

return review.question_list;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 객체를 감싸서 보내줘야 되는거 아닌가?? 🤔 ? 🤔흠 ㅋ 🤔

@holmir97 holmir97 merged commit 916ad30 into develop Jan 15, 2022
@holmir97 holmir97 deleted the feat/qestion-list branch January 15, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ priority: high 우선순위 높음 🍀 feature 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] get question-list
3 participants