Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/finish state #64

Merged
merged 3 commits into from
Jan 16, 2022
Merged

Fix/finish state #64

merged 3 commits into from
Jan 16, 2022

Conversation

holmir97
Copy link
Member

✅ PR check list

  • commit message가 적절한지 확인해주세요.
  • 마지막으로 Coding Convention을 준수했는지 확인해주세요.
  • 적절한 branch로 요청했는지 확인해주세요.
  • Assignees, Label을 붙여주세요.
  • 가능한 이슈를 Link 해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

finish state handling

📌 변경 사항

progress에 따른 finish state 변경

Linked Issue

close #62

@holmir97 holmir97 added 🔨 fix 오작동 코드 바로잡기 2️⃣ priority: middle 우선순위 중간 labels Jan 16, 2022
@holmir97 holmir97 self-assigned this Jan 16, 2022
Copy link
Member

@geeneve geeneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

returnCode.OK

@@ -88,7 +88,7 @@ const postReviewBeforeController = async (req: Request, res: Response) => {
false,
"요청값이 잘못되었습니다."
);
} else if (resData === -101) {
} else if (resData === constant.DB_NOT_FOUND) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 너무 좋습니다 😎

@holmir97 holmir97 merged commit 118140d into develop Jan 16, 2022
@holmir97 holmir97 deleted the fix/finish-state branch January 16, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2️⃣ priority: middle 우선순위 중간 🔨 fix 오작동 코드 바로잡기
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Review finish progress
2 participants