Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: response #7

Merged
merged 1 commit into from
Jan 10, 2022
Merged

feat: response #7

merged 1 commit into from
Jan 10, 2022

Conversation

holmir97
Copy link
Member

@holmir97 holmir97 commented Jan 10, 2022 •
edited
Loading

✅ PR check list

  • commit message가 적절한지 확인해주세요.
  • 마지막으로 Coding Convention을 준수했는지 확인해주세요.
  • 적절한 branch로 요청했는지 확인해주세요.
  • Assignees, Label을 붙여주세요.
  • 가능한 이슈를 Link 해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

response message 수정

📌 변경 사항

Linked Issue

#6

@holmir97 holmir97 added 🍀 feature 새로운 기능 추가 2️⃣ priority: middle 우선순위 중간 labels Jan 10, 2022
@holmir97 holmir97 self-assigned this Jan 10, 2022
geeneve
geeneve approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@geeneve geeneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 기가 막힌 코드네요!

seohyun-106
seohyun-106 approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@seohyun-106 seohyun-106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • success가 추가되었군요 !
  • 굿 ..

@holmir97 holmir97 merged commit aab6b3b into develop Jan 10, 2022
@holmir97 holmir97 deleted the feat/response branch January 10, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seohyun-106 seohyun-106 seohyun-106 approved these changes

@geeneve geeneve geeneve approved these changes

Assignees

@holmir97 holmir97

Labels
2️⃣ priority: middle 우선순위 중간 🍀 feature 새로운 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@holmir97 @seohyun-106 @geeneve