Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/book review api #70

Merged
merged 5 commits into from
Jan 17, 2022
Merged

Fix/book review api #70

merged 5 commits into from
Jan 17, 2022

Conversation

seohyun-106
Copy link
Contributor

@seohyun-106 seohyun-106 commented Jan 17, 2022

✅ PR check list

  • commit message가 적절한지 확인해주세요.
  • 마지막으로 Coding Convention을 준수했는지 확인해주세요.
  • 적절한 branch로 요청했는지 확인해주세요.
  • Assignees, Label을 붙여주세요.
  • 가능한 이슈를 Link 해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

  • DB Column 추가
  • response body 수정
  • request body 수정

📌 변경 사항

  • Book DB에 translator, publication_dt 추가
  • get/book response에 reviewId 추가
  • get/review response에 book 상세정보 객체 추가
  • post/book request, DB에 translator, publicationDate 추가

Linked Issue

close #68

@seohyun-106 seohyun-106 added 🔨 fix 오작동 코드 바로잡기 1️⃣ priority: high 우선순위 높음 labels Jan 17, 2022
@seohyun-106 seohyun-106 self-assigned this Jan 17, 2022
@@ -10,7 +10,10 @@ import returnCode from "../library/returnCode";
// slack
import slack from "../others/slack/slack";

export default (req: Request, res: Response, next) => {
import User from "../models/User";
import { promises } from "fs";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안쓰는 라브 지우기~

) => {
if (!isbn || !title || !author) {
if (!isbn || !title || !author || !translator || !publicationDate) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음.....?

title: book.title,
authors: book.author,
translators: book.translator,
publicationDate: book.publication_dt,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카멜케이스 쓰세요 ㅋ

@holmir97 holmir97 merged commit 0051b49 into develop Jan 17, 2022
@holmir97 holmir97 deleted the fix/book-review-api branch January 17, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ priority: high 우선순위 높음 🔨 fix 오작동 코드 바로잡기
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] api response body 수정사항
3 participants