Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: controller and service structure change #77

Merged
merged 1 commit into from
Jan 17, 2022
Merged

refactor: controller and service structure change #77

merged 1 commit into from
Jan 17, 2022

Conversation

geeneve
Copy link
Member

@geeneve geeneve commented Jan 17, 2022

✅ PR check list

  • commit message가 적절한지 확인해주세요.
  • 마지막으로 Coding Convention을 준수했는지 확인해주세요.
  • 적절한 branch로 요청했는지 확인해주세요.
  • Assignees, Label을 붙여주세요.
  • 가능한 이슈를 Link 해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

  • if else 에서 if return으로 변경해서 리팩토링 함

📌 변경 사항

  • if else에서 if return으로 변경
  • 함수 순서 변경

Linked Issue

close #74

@geeneve geeneve added 🌈 refactor 코드 리팩토링 2️⃣ priority: middle 우선순위 중간 labels Jan 17, 2022
@geeneve geeneve merged commit 0f2c0f6 into develop Jan 17, 2022
@geeneve geeneve deleted the refactor/controller-structure branch January 17, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seohyun-106 seohyun-106 Awaiting requested review from seohyun-106

@holmir97 holmir97 Awaiting requested review from holmir97

Assignees

@seohyun-106 seohyun-106

@geeneve geeneve

Labels
2️⃣ priority: middle 우선순위 중간 🌈 refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] controller structure
2 participants
@geeneve @seohyun-106