Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/get book detail api #97

Merged
merged 9 commits into from
Feb 10, 2022
Merged

Feat/get book detail api #97

merged 9 commits into from
Feb 10, 2022

Conversation

holmir97
Copy link
Member

@holmir97 holmir97 commented Feb 8, 2022

✅ PR check list

  • commit message가 적절한지 확인해주세요.
  • 마지막으로 Coding Convention을 준수했는지 확인해주세요.
  • 적절한 branch로 요청했는지 확인해주세요.
  • Assignees, Label을 붙여주세요.
  • 가능한 이슈를 Link 해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

  • Get Book api 를 세분화 하였습니다.
    get book/pre
    get book/peri
    get book/post

변수 변경: state -> reviewSt

📌 변경 사항

Linked Issue

close #88

@holmir97 holmir97 added 🍀 feature 새로운 기능 추가 🌈 refactor 코드 리팩토링 1️⃣ priority: high 우선순위 높음 labels Feb 8, 2022
@holmir97 holmir97 self-assigned this Feb 8, 2022
Copy link
Member

@geeneve geeneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋ 노션 의문사항 뭔소리인지 알겠다
-> 공통된 부분은 라이브러리에 함수로 추가해도 되지 않을까??
const getBooksByUserId = (userId: number) => {}

@holmir97 holmir97 merged commit dbb62a0 into develop Feb 10, 2022
@geeneve geeneve deleted the feat/book-detail-api branch February 11, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ priority: high 우선순위 높음 🍀 feature 새로운 기능 추가 🌈 refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] add refresh token
3 participants