Coal item, and generator requires coal

[WilcoDW]

Added a coal item with my original sprite that i created, the coal spawns in the world and is used to power the power generator.

also changed the way things spawn and included Ice in it from someone else's commit.

[guntherwullaert]

Sorry due to me you have conflicts now in the world generator
but you can easily add to the xml file your requirement :)

[WilcoDW]

Fixed the issues, added my coal to your new world generator system with XML

[AmusedNetwork]

Shouldn't the chances add up to 100%? Or are the percentages of each item being spawned individual? (currently it adds up to 130%)

[guntherwullaert]

everything above 100 % is ignored. You should change raw iron to 50 % ! Did it work correctly how it is now, because it should not ?

[WilcoDW]

Fixed,
<Ressource objectType="Raw Iron" maxStack="50" chance="0.7" /> <Ressource objectType="Ice" maxStack="10" chance="0.15" /> <Ressource objectType="Coal" maxStack="20" chance="0.15" />

we do need a better system for the future though

[guntherwullaert]

Perfect :D Should be ready to merge now. If only an moderator would be online now. Yeah that only is a system for the meantime...

[WilcoDW]

I cant get my precious coal to spawn, also the menus dont work, is it me? and does someone have a sollution

NullReferenceException: Object reference not set to an instance of an object MenuController.Start () (at Assets/Scripts/UI/InGameUI/MenuController.cs:31)

Thats one thing, i made it debug log the number of spawnable resources and it said 3, so far so good, then i made it debug log the objectType everytime it looped in the foreach, it only debug logs Raw Iron and Ice

[guntherwullaert]

Thank you, you found a bug .... there was some testing code in there Line 58 should be:
int chance = i.stackSize;

it was:

int chance = ressources[0].stackSize;

please change this as well, the menus should work though

[WilcoDW]

It works, thanks

[guntherwullaert]

Do you still have problems with the menus ?

[WilcoDW]

Yes but thats a bug i am going to file in the Issues page, you can take a look at it there

here: #503

[guntherwullaert]

ok thanks for committing the bug for me :) the coal is a really nice idea but wasn't there another guy with power cells or something ? Found it : #370 someone will need to decide which to take

[Grenkin1988]

#506 Made changes in order to enable power system to react on changes to powerValue

[WilcoDW]

Somehow fixed the UI issue, idk how

[Tranberry]

Are there natural occurrences of coal in space? Or at the least is it common in space?

[WilcoDW]

I am not too sure, i would think carbon is availible which is kinda the same, and we can always change it so it requires oxygen or something.

[guntherwullaert]

Best would be if there was a coal power generator and one on power cells. So that in the beginning you search for coal because that is the cheap way but coal is a limited resource and then you switch over to the power cell power generator so essentially we have two generators :)

[Tranberry]

I would switch to gas, but I won't complain more than maybe mod it later.

[Xeni91]

Well I decided to go with Power Cells, because we are in Space and are not human ... to go with gas or coal seems a bit boring

[WilcoDW]

but why do we use iron and steel? if we are not human we might as well be using different metals or different materials all together

[Xeni91]

was not my idea just saying ^^ and yes you are right

[Tranberry]

@wilcomega I'm with you on that, but iron is 'common'.

[WilcoDW]

True :) but coal is eesentially just carbon, isnt that common too? and we can and probably will change it in the future anyways to something more fitting but for now i think this is a good addition

[WardBenjamin]

Fyi, you can't find coal and oil in space since they're both made from biologicals and require huge amounts of compression and such, which will only happen in a gravity well.

Maybe swap out coal with something else? Some kind of nuclear fuel like uranium or something?

[guntherwullaert]

@WardBenjamin can you take only that bug fix or should I make a new pull request ? Because that is kind off important

[WilcoDW]

If you guys want to you can swap coal out for uranium or something similar. but i am waiting for this thing to get merged or closed

[guntherwullaert]

yes me as well

[WardBenjamin]

@wilcomega @gunthergun I'm going to close this, but please do open a new PR with the bug fix!

[guntherwullaert]

@WardBenjamin #495 fixes all of the bugs in the worldgenerator :)

[WilcoDW]

@WardBenjamin The bugs are fixed, could you be so kind to re-open it?

[guntherwullaert]

@wilcomega he closed this because he does not want coal if you want to have such a system you should make a new PR with uranium or something

[WardBenjamin]

@wilcomega @gunthergun I mean, I'm not opposed to having coal in the game, but it's not something that we should have generating in asteroids. As far as those go, basically only metals, carbon, and other elements/simple compounds (silicon would be a cool one to add, for computers and stuff) show up in asteroids, and things like ammonia and water (along with misc. rock) show up in comets.

[guntherwullaert]

@WardBenjamin thanks for clearing that up

[WilcoDW]

New one is #524